Check if optional license is in available values #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guts
approved these changes
Jun 23, 2024
gounux
changed the title
super idée ! c'est fait |
Guts
requested changes
Jun 24, 2024
Guts
approved these changes
Jun 24, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #215 +/- ##
==========================================
- Coverage 67.12% 67.02% -0.11%
==========================================
Files 43 43
Lines 1956 1971 +15
Branches 347 351 +4
==========================================
+ Hits 1313 1321 +8
- Misses 561 567 +6
- Partials 82 83 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Guts
added a commit
that referenced
this pull request
Jul 2, 2024
- vu que je fais joujou avec les enums en ce moment dans d'autres projets (DicoGIS), ça m'a donné des idées - j'en ai profité pour ajouter la docstring sur la fonction impactée Pour info, je n'ai pas retiré "license" puisque c'est fait dans #215
Guts
force-pushed
the
fix/remove-license-from-header-check
branch
from
a7284db
to
b7be023
Compare
|
@gounux je te laisse la main ;) |
|
|
@Guts tu peux merger comme un sagouin (coin coin !) ? Flemme de relancer les tests Win qui plantent :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.